lkml.org 
[lkml]   [2010]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[38/98] [SCSI] scsi_dh: create sysfs file, dh_state for all SCSI disk devices
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Chandra Seetharaman <sekharan@us.ibm.com>

    commit 5917290ce9b376866b165d02a5ed88d5ecdb32d0 upstream.

    Create the sysfs file, dh_state even if the new SCSI device is not
    in the any of the device handler's internal lists.

    Signed-Off-by: Chandra Seetharaman <sekharan@us.ibm.com>
    Acked-by: Hannes Reinecke <hare@suse.de>
    Signed-off-by: James Bottomley <James.Bottomley@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/scsi/device_handler/scsi_dh.c | 11 ++++-------
    1 file changed, 4 insertions(+), 7 deletions(-)

    --- a/drivers/scsi/device_handler/scsi_dh.c
    +++ b/drivers/scsi/device_handler/scsi_dh.c
    @@ -304,18 +304,15 @@ static int scsi_dh_notifier(struct notif
    sdev = to_scsi_device(dev);

    if (action == BUS_NOTIFY_ADD_DEVICE) {
    + err = device_create_file(dev, &scsi_dh_state_attr);
    + /* don't care about err */
    devinfo = device_handler_match(NULL, sdev);
    - if (!devinfo)
    - goto out;
    -
    - err = scsi_dh_handler_attach(sdev, devinfo);
    - if (!err)
    - err = device_create_file(dev, &scsi_dh_state_attr);
    + if (devinfo)
    + err = scsi_dh_handler_attach(sdev, devinfo);
    } else if (action == BUS_NOTIFY_DEL_DEVICE) {
    device_remove_file(dev, &scsi_dh_state_attr);
    scsi_dh_handler_detach(sdev, NULL);
    }
    -out:
    return err;
    }




    \
     
     \ /
      Last update: 2010-01-27 00:59    [W:4.485 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site