Messages in this thread | | | Date | Tue, 26 Jan 2010 15:16:06 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH v3] oom-kill: add lowmem usage aware oom kill handling |
| |
On Mon, 25 Jan 2010 15:15:03 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> -unsigned long badness(struct task_struct *p, unsigned long uptime) > +unsigned long badness(struct task_struct *p, unsigned long uptime, > + int constraint)
And badness() should be renamed to something better (eg, oom_badness), and the declaration should be placed in a mm-specific header file.
Yes, the code was already like that. But please don't leave crappiness in place when you come across it - take the opportunity to fix it up.
| |