lkml.org 
[lkml]   [2010]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3] oom-kill: add lowmem usage aware oom kill handling
    On Mon, 25 Jan 2010 15:15:03 +0900
    KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:

    > -unsigned long badness(struct task_struct *p, unsigned long uptime)
    > +unsigned long badness(struct task_struct *p, unsigned long uptime,
    > + int constraint)

    And badness() should be renamed to something better (eg, oom_badness), and
    the declaration should be placed in a mm-specific header file.

    Yes, the code was already like that. But please don't leave crappiness in
    place when you come across it - take the opportunity to fix it up.


    \
     
     \ /
      Last update: 2010-01-27 00:19    [W:0.029 / U:149.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site