Messages in this thread | | | Subject | Re: [PATCH 01/01] regulator: support max8649 | From | Liam Girdwood <> | Date | Tue, 26 Jan 2010 16:10:49 +0000 |
| |
On Tue, 2010-01-26 at 07:14 -0500, Haojian Zhuang wrote: > On Tue, Jan 26, 2010 at 7:00 AM, Mark Brown > <broonie@opensource.wolfsonmicro.com> wrote: > > On Tue, Jan 26, 2010 at 06:54:48AM -0500, Haojian Zhuang wrote: > >> On Tue, Jan 26, 2010 at 6:04 AM, Mark Brown > > > >> > I'd expect the time taken to enable to be the voltage multipled by the > >> > step size rather than divided by the step size? > > > >> I don't agree at this point. The unit of step is uV/uSec. The function > >> should return uSec. So voltage divided by the step is more reasonable. > > > > Ah, then the variable step is confusingly named since it's actually a > > rate of change rather than a step size - I'd suggest rate or something > > like that instead. > > > > update this patch. >
Applied.
Thanks
Liam
| |