lkml.org 
[lkml]   [2010]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/8] percpu: add __percpu sparse annotations to hw_breakpoint
    On Tue, Jan 26, 2010 at 11:34:40AM +0900, Tejun Heo wrote:
    > On 01/26/2010 11:22 AM, Frederic Weisbecker wrote:
    > >> What about this? It doesn't use direct cast to scalar but should
    > >> create a pointer type to kernel space datas:
    > >>
    > >>
    > >> #define kernel_space_t(var) \
    > >> (typeof(var) __kernel __force)
    > >
    > >
    > > Should be typeof(*var)
    > >
    > >>
    > >> #define SHIFT_PERCPU_PTR(__p, __offset) ({ \
    > >> __verify_pcpu_ptr((__p)); \
    > >> RELOC_HIDE((typeof(*(kernel_space_t(var)) __kernel __force *)(__p), (__offset)); \
    > >> })
    >
    > Can you balance ()'s here too?


    #define kernel_space_t(var) \
    (typeof(*(var)) __kernel __force)


    /* Weird cast keeps both GCC and sparse happy. */
    #define SHIFT_PERCPU_PTR(__p, __offset) ({ \
    __verify_pcpu_ptr((__p)); \
    RELOC_HIDE((typeof(*(kernel_space_t(__p))) __kernel __force *)(__p), (__offset)); \
    })

    #define per_cpu(var, cpu) \
    (*SHIFT_PERCPU_PTR(&(var), per_cpu_offset(cpu)));


    No guarantee that will build. I should pull your tree and install
    sparse (yeah, shame on me, I've never installed it).



    \
     
     \ /
      Last update: 2010-01-26 03:37    [W:0.026 / U:0.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site