Messages in this thread | | | Date | Mon, 25 Jan 2010 20:25:40 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] platform_driver_register: warn if probe is in .init.text |
| |
Hello Dmitry,
> > > > + if (drv->probe && kernel_init_text_address((unsigned long)drv->probe)) > > > > + pr_warning("oops-warning: probe function of platform driver %s" > > > > + " lives in .init.text\n", drv->driver.name); > > > > +#else > > > > + /* > > > > + * without HOTPLUG probe functions can be discarded after the driver is > > > > + * loaded. > > > > + * There is a little chance for false positives, namely if the driver is > > > > + * registered after the .init sections are discarded. > > > > + */ > > > > + if (drv->probe && !kernel_init_text_address((unsigned long)drv->probe)) > > > > + pr_info("probably the probe function of platform driver %s can" > > > > + " be moved to .init.text\n", drv->driver.name); > > > > > > It really depends on the user's (or rather builder's) local > > > configuration so how can we make this suggestion? > > Can you point out a situation that makes the suggestion wrong? AFAIK > > there only the possibility that the driver is loaded after .init is > > discarded (as written in the comment). > > > > The presence of CONFIG_HOTPLUG depends on particular .config, so, for > example, you may not have it set while I have. So you will boot, get the > suggestion, submit a patch, then I will boot and will get a warning that > the probe function is in wrong section. > > So in general I wonder if it is possible to request that all probe > functions are marked as __devinit or not marked at all, regardless of > CONFIG_HOTPLUG and CONFIG_MODULE settings. Would you agree if the message would change to
probably the probe function of platform driver %s can be moved to .devinit.text
?
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |