lkml.org 
[lkml]   [2010]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: Introduction to rar_register patch set of 5 patches
Greg:

Just to be clear; then only the overall description of RAR should be in the cover email?

Perhaps I over reacted to you earlier comment that each patch had too much, so I moved everything to the intro email.

I will re-submit with the description of each patch in each patch, but I will still list the patches in the intro.

Mark

-----Original Message-----
From: Greg KH [mailto:greg@kroah.com]
Sent: Friday, January 22, 2010 10:33 AM
To: Randy Dunlap
Cc: Allyn, Mark A; linux-kernel@vger.kernel.org; alan@linux.intel.com; Johnson, Charles F
Subject: Re: Introduction to rar_register patch set of 5 patches
On Fri, Jan 22, 2010 at 10:23:08AM -0800, Randy Dunlap wrote:
> On Fri, 22 Jan 2010 09:53:30 -0800 Mark Allyn wrote:
>
> > The following five patches are for the Restricted Access Region
> > Register (rar_register) driver.
> >
> > This driver is for the Intel MID platform.
>
> Hi Mark,
>
> Please read and try to follow Documentation/SubmittingPatches.
>
> E.g.:
>
> "The canonical patch subject line is:
>
> Subject: [PATCH 001/123] subsystem: summary phrase"
>
> so your patch 1 should be more like:
>
> [PATCH 1/5] rar_register: rename rar_driver to rar_register
>
> and then that one patch's description should be at the top of that
> email's body, not in the patch introduction/cover email.
>
> As it stands, these 5 patch descriptions need to be moved
> to each patch's patch description...

I agree, I can not apply these as-is.

Mark, please redo the patches.

Hint, we do have tools that make this much easier, like quilt and git,
you might take the time to learn to use them so that future patch
submissions are not bungled as badly as these have been.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-01-22 21:03    [from the cache]
©2003-2011 Jasper Spaans