Messages in this thread | | | Date | Fri, 22 Jan 2010 10:23:08 -0800 | From | Randy Dunlap <> | Subject | Re: Introduction to rar_register patch set of 5 patches |
| |
On Fri, 22 Jan 2010 09:53:30 -0800 Mark Allyn wrote:
> The following five patches are for the Restricted Access Region > Register (rar_register) driver. > > This driver is for the Intel MID platform.
Hi Mark,
Please read and try to follow Documentation/SubmittingPatches.
E.g.:
"The canonical patch subject line is:
Subject: [PATCH 001/123] subsystem: summary phrase"
so your patch 1 should be more like:
[PATCH 1/5] rar_register: rename rar_driver to rar_register
and then that one patch's description should be at the top of that email's body, not in the patch introduction/cover email.
As it stands, these 5 patch descriptions need to be moved to each patch's patch description...
> There are five patches. They are: > > Patch 1 of 5 for rar_register; renaming to rar_register > This renames the current rar resigter driver to > the name rar_register. This is to differentiate > it from the rar_handler driver, which will be > submitted later. > Patch 2 of 5 for rar_register - renaming directory to rar_register > This renames the directory in which the driver files > are located; again for clarity. > Patch 3 of 5 for rar_register - provide better explanation in Kconfig > This patch provides a better explanation of what this > driver is for in the Kconfig file > Patch 4 of 5 for rar_register - fix checkpatch errors and debug header > This patch cleans up checkpatch errors and warnings as well as > fixes bugs in the rar_register.h header file > Patch 5 of 5 for rar_register - fix checkpatch errors and debug program file > This patch cleans up checkpatch errors and warnings as well as > fixes bugs in the rar_register.c program file > > Please note that patches 1, 2, and 3 are for 'housekeeping'. They do nothing > to correct any checkpatch errors/warnings in the driver. > > Patches 4 and 5 clean up checkpatch issues in the rar_register.h and > rar_register.c file respectively. > > After patch 5 is applied, there should be no checkpatch issues in the entire > driver directory > > > Please note that I did a test build of this patch set after patch 3 and after > patch 5 of this set. > > If there are issues with either patch 4 or patch 5, you can still submit > patches 1, 2, and 3 and expect a clean build. > > These patches were applied against the kernel next that I pulled as of Wednesday, > January 21, 2010.
Thanks, --- ~Randy
| |