[lkml]   [2010]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 05/36] x86/pci: enable pci root res read out for 32bit too

    On Wed, 20 Jan 2010, Yinghai Lu wrote:
    > printk(KERN_DEBUG "bus: %02x index %x %s: [%llx, %llx]\n",
    > busnum, j,
    > (res->flags & IORESOURCE_IO)?"io port":"mmio",
    > - res->start, res->end);
    > + (u64)res->start, (u64)res->end);

    When fixing these kinds of things, please just make it use '%pR' instead.

    A simple

    printk(KERN_DEBUG "bus: %02x index %x %pR\n", busnum, j, res);

    should do the right thing, printing the resource with nice human-readable
    flags. Including things like 64-bit/prefetching information for memory
    resources etc that the current manual resource printout doesn't do.


     \ /
      Last update: 2010-01-21 16:57    [W:0.020 / U:7.680 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site