Messages in this thread | | | Date | Thu, 21 Jan 2010 13:02:26 +0100 | From | Frederic Weisbecker <> | Subject | Re: [PATCH] perf_events: improve x86 event scheduling (v5) |
| |
On Thu, Jan 21, 2010 at 12:44:03PM +0100, Stephane Eranian wrote: > > If the scheduling validation fails, then you just need to rollback > > the whole group. > > > > That's sensibly what you did in your patch, right? Except the loop > > is now handled by the core code. > > > > > Ok, I think I missed where you were actually placing that loop. > So you want to do this in group_sched_in(), right?
Exactly!
> > > > I don't understand why that can't be done with the above model. > > In your patch we iterate through the whole group, collect events, > > and schedule them. > > > > With the above, the collection is just done on enable(), and the scheduling > > is done with the new pmu callbacks. > > > > The thing is sensibly the same, where is the obstacle? > > > There is none. You've just hoisted the some of the code from > hw_perf_group_sched_in().
Exactly :)
| |