lkml.org 
[lkml]   [2010]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRE: [PATCH/RFC v1 0/2] Human readable performance event description in sysfs
    > -----Original Message-----
    > From: linux-arm-kernel-bounces@lists.infradead.org [mailto:linux-arm-
    > kernel-bounces@lists.infradead.org] On Behalf Of Russell King - ARM
    > Linux
    > Sent: Wednesday, January 20, 2010 10:58 AM
    > To: Tomasz Fujak
    > Cc: jpihet@mvista.com; peterz@infradead.org; p.osciak@samsung.com;
    > jamie.iles@picochip.com; will.deacon@arm.com; linux-
    > kernel@vger.kernel.org; kyungmin.park@samsung.com; mingo@elte.hu;
    > linux-arm-kernel@lists.infradead.org; m.szyprowski@samsung.com
    > Subject: Re: [PATCH/RFC v1 0/2] Human readable performance event
    > description in sysfs
    >
    > On Wed, Jan 20, 2010 at 10:11:44AM +0100, Tomasz Fujak wrote:
    > > The following patches provide a sysfs entry with hardware event human
    > > readable description in the form of "0x%llx\t%lld-%lld\t%s\t%s" %
    > > (event_value, minval, maxval, name, description)
    >
    > I think your patch is in violation of this from
    > Documentation/filesystems/sysfs.txt:
    >
    > Attributes
    > ~~~~~~~~~
    > ...
    > Attributes should be ASCII text files, preferably with only one value
    > per file. It is noted that it may not be efficient to contain only one
    > value per file, so it is socially acceptable to express an array of
    > values of the same type.
    >
    > Mixing types, expressing multiple lines of data, and doing fancy
    > formatting of data is heavily frowned upon. Doing these things may get
    > you publically humiliated and your code rewritten without notice.

    1. There are numerous exceptions:
    $ find /sys -exec grep -HC ^ {} \; 2>/dev/null | grep ":[3-9]$" | grep -c
    yielded 43 on my machine.
    Some of them list multiple lines with fancy formatting each (i.e.:
    /sys/class/Bluetooth/l2cap or devices/pci*/resource)

    2. There are sysfs entries regarding the performance counters already:
    'overcommit' and 'reserve_percpu'
    They are simple, I admit, but I find it useful to have all relevant thing in
    one place.

    If the above does not convince you, I could move the file to the debugfs.

    >
    >
    > _______________________________________________
    > linux-arm-kernel mailing list
    > linux-arm-kernel@lists.infradead.org
    > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



    \
     
     \ /
      Last update: 2010-01-20 11:25    [W:0.025 / U:0.996 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site