lkml.org 
[lkml]   [2010]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] tracing: Change trace_seq to use separate buffer
On Tue, Jan 19, 2010 at 03:34:16PM +0800, Lai Jiangshan wrote:
> @@ -526,19 +526,19 @@ event_format_read(struct file *filp, char __user *ubuf, size_t cnt,
> {
> struct ftrace_event_call *call = filp->private_data;
> struct ftrace_event_field *field;
> - struct trace_seq *s;
> + struct trace_seq seq, *s = &seq;
> + unsigned char *buffer;
> int common_field_count = 5;
> - char *buf;
> int r = 0;
>
> if (*ppos)
> return 0;
>
> - s = kmalloc(sizeof(*s), GFP_KERNEL);
> - if (!s)
> + buffer = (unsigned char *)__get_free_page(GFP_KERNEL);
> + if (!buffer)
> return -ENOMEM;
>
> - trace_seq_init(s);
> + trace_seq_init(s, buffer, PAGE_SIZE);



May be can we use a paired trace_seq_init_page/trace_seq_free_page,
to sum up a bit the above pattern.



\
 
 \ /
  Last update: 2010-01-20 19:59    [W:0.148 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site