lkml.org 
[lkml]   [2010]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf tools: fix write_event()
From
Date
On Wed, 2010-01-20 at 14:41 +0100, Peter Zijlstra wrote:
> On Wed, 2010-01-20 at 21:34 +0800, Xiao Guangrong wrote:
> > We parse the event while it's read from mmap buffer in
> > write_event(), but sometimes the event will straddles the
> > mmap boundary, we should handle this case
> >
> > And if we record events(such as perf kmem/sched) for long
> > times, Ctrl + C can't interrupt it just for this reason
>
> Uhm, how why? it didn't used to know about events and just copied the
> data.

looks like acme wrecked it in f5a2c3dc.. anyway the fix is wrong, record
should not know or care about the actual events and simply write data
out.



\
 
 \ /
  Last update: 2010-01-20 14:47    [W:0.137 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site