Messages in this thread | | | Subject | Re: [PATCH] perf tools: fix write_event() | From | Peter Zijlstra <> | Date | Wed, 20 Jan 2010 14:44:56 +0100 |
| |
On Wed, 2010-01-20 at 14:41 +0100, Peter Zijlstra wrote: > On Wed, 2010-01-20 at 21:34 +0800, Xiao Guangrong wrote: > > We parse the event while it's read from mmap buffer in > > write_event(), but sometimes the event will straddles the > > mmap boundary, we should handle this case > > > > And if we record events(such as perf kmem/sched) for long > > times, Ctrl + C can't interrupt it just for this reason > > Uhm, how why? it didn't used to know about events and just copied the > data.
looks like acme wrecked it in f5a2c3dc.. anyway the fix is wrong, record should not know or care about the actual events and simply write data out.
| |