Messages in this thread | | | Date | Sat, 02 Jan 2010 11:48:04 +0530 | From | David John <> | Subject | Re: [Regression] 2.6.33-rc2 - pci: Commit e0cd516 causes OOPS |
| |
On 01/02/2010 03:52 AM, Yinghai Lu wrote: > On Fri, Jan 1, 2010 at 11:50 AM, David John <davidjon@xenontk.org> wrote: >> Hi All, >> >> Commit e0cd516 causes an null pointer dereference when reading from the >> sysfs attributes local_cpu* on Intel machines with no ACPI NUMA >> proximity info, since dev->numa_node gets set to -1 for all PCI devices, >> which then gets passed to cpumask_of_node. >> >> The patch following this mail fixes the problem for x86. Perhaps a more >> thorough solution would be to fix the PCI layer to set the node >> information for devices to zero rather than -1 (Since if CONFIG_NUMA=y >> we have node 0)? I don't know whether it is safe / correct to do this. > > no. > > 1. -1, mean calling code will use node that code is running on. > 2. the system that have two or more nodes, and more peer root buses. > if the first node doesn't have RAM installed, no node0 then. > > YH >
Oh I see. Thanks.
Regards, David.
| |