Messages in this thread Patch in this message | | | Date | Wed, 20 Jan 2010 03:08:30 +0100 | From | Roel Kluin <> | Subject | [PATCH] sfc: EFX_ETHTOOL_STAT calculates the offset of the efx##source_name's field in both cases |
| |
EFX_ETHTOOL_STAT calculated the offset of the efx##source_name's field Regardless of whether that field was NULL.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- This looks like a bug, but I am not sure whether I understood this correctly, nor was it tested, was this intended?
diff --git a/drivers/net/sfc/ethtool.c b/drivers/net/sfc/ethtool.c index 6c0bbed..722bac7 100644 --- a/drivers/net/sfc/ethtool.c +++ b/drivers/net/sfc/ethtool.c @@ -41,7 +41,7 @@ struct efx_ethtool_stat { .source = EFX_ETHTOOL_STAT_SOURCE_##source_name, \ .offset = ((((field_type *) 0) == \ &((struct efx_##source_name *)0)->field) ? \ - offsetof(struct efx_##source_name, field) : \ + offsetof(struct efx_##stat_name, field) : \ offsetof(struct efx_##source_name, field)), \ .get_stat = get_stat_function, \ }
| |