| Date | Mon, 18 Jan 2010 20:24:45 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH 39/40] gfs2: use workqueue instead of slow-work |
| |
On 01/18/2010 06:45 PM, Steven Whitehouse wrote: > Hi, > > On Mon, 2010-01-18 at 09:57 +0900, Tejun Heo wrote: >> Workqueue can now handle high concurrency. Use system_long_wq instead >> of slow-work. >> >> Signed-off-by: Tejun Heo <tj@kernel.org> >> Cc: Steven Whitehouse <swhiteho@redhat.com> > > Acked-by: Steven Whitehouse <swhiteho@redhat.com> on two conditions: > > i) That scheduling work on this new workqueue will not require any > GFP_KERNEL allocations (even hidden ones such as starting new threads) > before the work runs. This is required since the recovery code must not > call into the fs until after its recovered.
Oh, if that's the case, it needs its own wq with a rescuer. I thought the recovery path wasn't invoked during allocation. slow-work didn't guarantee such thing either. Anyways, changing that is pretty easy.
Thanks.
-- tejun
|