Messages in this thread | | | Subject | Re: [PATCH] sched: cpuacct: Use bigger percpu counter batch values for stats counters | From | Peter Zijlstra <> | Date | Mon, 18 Jan 2010 09:34:41 +0100 |
| |
On Mon, 2010-01-18 at 19:21 +1100, Anton Blanchard wrote: > Hi Peter, > > > Seems like a good idea, but isn't that batch number rather static? If > > so, computing it in some init path would save that multiply on the > > actual accounting path. > > It is mostly static, but percpu_counter_batch does change with hotplug > operations. Adding a hotplug notifier felt like a lot of work but I was > worried we have issues if we didn't scale with hotplug add operations.
OK, trading a notifier for a mult might be worth it, we'll see if someone complains ;-)
Lets got with this for now.
| |