lkml.org 
[lkml]   [2010]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: mcs7830 usb net: "scheduling while atomic" danger?
    Julia,

    On Mon, 18 Jan 2010, Julia Lawall wrote:
    > On Mon, 18 Jan 2010, Andreas Mohr wrote:
    >
    > The semantic match shown below finds 55 matches. All but two involve
    > mutex_lock. Those are in the file

    As I said before the mutex_lock()/msleep() ones are fine.

    > /var/linuxes/linux-next/drivers/usb/host/ehci-hub.c
    > in the functions ehci_bus_suspend and ehci_hub_control.

    The msleep in ehci_hub_control() which happens with ehci->lock held
    and irqs disabled is definitely buggy.

    I can't see anything wrong wth the msleep in ehci_bus_suspend() as it
    is _before_ the spin_lock_irq(&ehci->lock) region.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2010-01-18 22:27    [W:0.023 / U:30.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site