lkml.org 
[lkml]   [2010]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 3/9] drivers/net: Eliminate useless code
    From: Julia Lawall <julia@diku.dk>

    The variable qdev is initialized twice to the same (side effect-free)
    expression. Drop one initialization.

    A simplified version of the semantic match that finds this problem is:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @forall@
    idexpression *x;
    identifier f!=ERR_PTR;
    @@

    x = f(...)
    ... when != x
    (
    x = f(...,<+...x...+>,...)
    |
    * x = f(...)
    )
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---
    drivers/net/qla3xxx.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
    index f922294..4ef0afb 100644
    --- a/drivers/net/qla3xxx.c
    +++ b/drivers/net/qla3xxx.c
    @@ -4087,7 +4087,6 @@ static void __devexit ql3xxx_remove(struct pci_dev *pdev)
    struct ql3_adapter *qdev = netdev_priv(ndev);

    unregister_netdev(ndev);
    - qdev = netdev_priv(ndev);

    ql_disable_interrupts(qdev);


    \
     
     \ /
      Last update: 2010-01-18 09:15    [W:0.032 / U:210.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site