lkml.org 
[lkml]   [2010]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/64] pata_cypress: fix PIO timings underclocking
Hello.

Bartlomiej Zolnierkiewicz wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] pata_cypress: fix PIO timings underclocking
>
> Timing registers should be programmed with the desired number of clocks
> minus one clock.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> drivers/ata/pata_cypress.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> Index: b/drivers/ata/pata_cypress.c
> ===================================================================
> --- a/drivers/ata/pata_cypress.c
> +++ b/drivers/ata/pata_cypress.c
>
[...]
> @@ -79,7 +81,7 @@ static void cy82c693_set_piomode(struct
> pci_read_config_dword(pdev, CY82_IDE_ADDRSETUP, &addr);
>
> addr &= ~0xF0; /* Mask bits */
> - addr |= (clamp_val(t.setup, 0, 15) << 4);
> + addr |= (clamp_val(t.setup - 1, 0, 15) << 4);
>

You could drop the unneeded parens while at it...

MBR, Sergei



\
 
 \ /
  Last update: 2010-01-18 20:09    [W:0.547 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site