| Date | Mon, 18 Jan 2010 17:52:56 +0000 | From | Alan Cox <> | Subject | Re: [PATCH 07/64] pata_atiixp: enable parallel scan |
| |
> const struct ata_port_info *ppi[] = { &info, &info }; > + struct ata_host *host; > + int rc; > > - return ata_pci_sff_init_one(pdev, ppi, &atiixp_sht, NULL); > + /* enable device and prepare host */ > + rc = pcim_enable_device(pdev); > + if (rc) > + return rc; > + > + rc = ata_pci_sff_prepare_host(pdev, ppi, &host); > + if (rc) > + return rc; > + > + host->flags |= ATA_HOST_PARALLEL_SCAN; > + > + pci_set_master(pdev); > + > + return ata_pci_sff_activate_host(host, ata_sff_interrupt, &atiixp_sht); > }
Adding a small essay to each host that activates parallel scan doesn't make sense. This should be a helper (ignore that if you make it a helper later in the patch set...)
|