Messages in this thread | | | Date | Mon, 18 Jan 2010 07:25:23 -0800 | From | Arjan van de Ven <> | Subject | Re: [PATCH 32/40] async: introduce workqueue based alternative implementation |
| |
On Mon, 18 Jan 2010 17:49:39 +0900 Tejun Heo <tj@kernel.org> wrote:
> For what async is currently used for, I don't think there will be any > noticeable difference. If the proposed implementation is lacking > somewhere, we can definitely improve it although I'm not sure whether > it will end up with the cookie thing.
it is not that I do not like your backend implementation. I do not like the programming model change you're introducing. The cookie API allows for what is sort of the equivalent of out-of-order execution that the cpu does. In a very very simple way, you can start things in an order, then they execute in variable times and in parallel, and then when the side effects need to become visible (device registration, whatever), you go back to an in-order model. I have patches to do this for KMS and we're working on getting something working for ACPI as well.
Your API/model change gets rid of this conceptually simple programming model, which makes using it on other places more complex and messy. I do not see what enormous benefit your patches would have that would justify complicating the programming model. (And "sharing the thread pool" is not that; I'm sure it's possible to share the thread pool without changing the programming model... and it's not that the async thread pools are that big or complex anyway)
So consider the current patches
NAK-ed-by: Arjan van de Ven <arjan@linux.intel.com>
-- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |