Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH 6/6] vfs: introduce FMODE_NEG_OFFSET for allowing negative f_pos | Date | Mon, 18 Jan 2010 10:59:10 +0900 |
| |
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> writes:
>> BTW, another concern by negative "pos" value is, the following like code >> >> pos >> shift_bits >> >> it will break the above. So, I think it should be checked if not yet. > > Where do we check ? > > FMODE_NEG_OFFSET is just used by /dev/mem and /proc/<pid>/mem. And I don't > think there are no additonal users. So, I myself don't have has such concerns...
Sorry, it's just my concern. I'm not checking real path (e.g. vfs) of related to /dev/mem, if there is no user of such code, it's ok.
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |