Messages in this thread |  | | | Date | Sun, 17 Jan 2010 12:40:36 +0100 | | From | Stefan Richter <> | | Subject | Re: [PATCH 1/9] drivers/char: Eliminate useless code |
| |
Julia Lawall wrote: > The variable x is initialized twice to the same (side effect-free) > expression. Drop one initialization. [...] > --- a/drivers/char/mmtimer.c > +++ b/drivers/char/mmtimer.c > @@ -546,9 +546,9 @@ static void mmtimer_tasklet(unsigned long data) > { > int nodeid = data; > struct mmtimer_node *mn = &timers[nodeid]; > - struct mmtimer *x = rb_entry(mn->next, struct mmtimer, list); > + struct mmtimer *x; > struct k_itimer *t; > unsigned long flags;
The next x = rb_entry(mn->next, struct mmtimer, list); is preceded by a test whether mn->next is NULL.
Unless that test is redundant too, your patch fixes a potential NULL pointer dereference, introduced by commit cbacdd95 "SGI Altix mmtimer: allow larger number of timers per node" in 2.6.26. -- Stefan Richter -=====-==-=- ---= =---= http://arcgraph.de/sr/
|  |