lkml.org 
[lkml]   [2010]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/9] drivers/char: Eliminate useless code
    From: Julia Lawall <julia@diku.dk>

    The variable x is initialized twice to the same (side effect-free)
    expression. Drop one initialization.

    A simplified version of the semantic match that finds this problem is:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @forall@
    idexpression *x;
    identifier f!=ERR_PTR;
    @@

    x = f(...)
    ... when != x
    (
    x = f(...,<+...x...+>,...)
    |
    * x = f(...)
    )
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---
    drivers/char/mmtimer.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/char/mmtimer.c b/drivers/char/mmtimer.c
    index 918711a..04fd0d8 100644
    --- a/drivers/char/mmtimer.c
    +++ b/drivers/char/mmtimer.c
    @@ -546,9 +546,9 @@ static void mmtimer_tasklet(unsigned long data)
    {
    int nodeid = data;
    struct mmtimer_node *mn = &timers[nodeid];
    - struct mmtimer *x = rb_entry(mn->next, struct mmtimer, list);
    + struct mmtimer *x;
    struct k_itimer *t;
    unsigned long flags;


    \
     
     \ /
      Last update: 2010-01-16 16:59    [W:0.022 / U:59.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site