Messages in this thread Patch in this message |  | | | Date | Sat, 16 Jan 2010 09:43:10 GMT | | From | tip-bot for Li Zefan <> | | Subject | [tip:tracing/urgent] tracing/filters: Fix MATCH_FRONT_ONLY filter matching |
| |
Commit-ID: 285caad415f459f336247932b4db95a571357a02 Gitweb: http://git.kernel.org/tip/285caad415f459f336247932b4db95a571357a02 Author: Li Zefan <lizf@cn.fujitsu.com> AuthorDate: Thu, 14 Jan 2010 10:53:21 +0800 Committer: Steven Rostedt <rostedt@goodmis.org> CommitDate: Thu, 14 Jan 2010 22:38:05 -0500
tracing/filters: Fix MATCH_FRONT_ONLY filter matching
MATCH_FRONT_ONLY actually is a full matching:
# ./perf record -R -f -a -e lock:lock_acquire \ --filter 'name ~rcu_*' sleep 1 # ./perf trace (no output)
We should pass the length of the pattern string to strncmp().
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> LKML-Reference: <4B4E8721.5090301@cn.fujitsu.com> Acked-by: Frederic Weisbecker <fweisbec@gmail.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- kernel/trace/trace_events_filter.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c index 50504cb..11c3973 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -261,7 +261,7 @@ static int regex_match_full(char *str, struct regex *r, int len) static int regex_match_front(char *str, struct regex *r, int len) { - if (strncmp(str, r->pattern, len) == 0) + if (strncmp(str, r->pattern, r->len) == 0) return 1; return 0; }
|  |