lkml.org 
[lkml]   [2010]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] fanotify: Add pids to events
On Fri, Jan 15, 2010 at 04:12:09PM +0100, Andreas Gruenbacher wrote:
> On Friday 15 January 2010 05:41:10 Matthew Helsley wrote:
> > Eric, you never replied to my point about pid namespaces
> > (http://lkml.org/lkml/2009/7/1/2). I'm still concerned that it's a
> > problem for this patch. I've cc'd some pid namespace folks, listed the
> > problems, and some alternative solutions (where I could think of any)
> > below:
> >
> > 1. Since fanotify doesn't hold a reference to the struct pid then the
> > pid can become stale before the event is acted upon.
> > solution a: Just ignoring this problem, like other interfaces
> > often do, is probably ok.
> > ... ?
> > solution z: Seems to require taking a reference to the pid and
> > giving userspace a way to drop the reference after it's done using
> > this value to refer to the process (yuck).
>
> struct fsnotify_event->tgid does hold a reference to the appropriate struct
> pid. The reference is released when that struct fsnotify_event is freed.

OK.

>
> > 2. If the event recipient does a clone and enters a new pidns the pid
> > number will be incorrect without any indication.
>
> No, if a process has a pid within the listener's namespace the listener will
> see this pid; otherwise, the resulting pid value is 0.

So the pid reference is resolved at read(), correct? If so then that's fine.
(Otherwise I'd think the values could still become stale).

> > 3. If the listening process is not in the same or an ancestor pid
> > namespace of the triggering process then there is no correct pid
> > corresponding to the event.
>
> Indeed, if the listener is not in the same or an ancestor pid namespace, the
> pid in the event will end up as 0. The event still indicates that something
> has happened to a file the listener is interested in though, it's just unclear
> who triggered the event. I don't see a problem with that though -- do you?

Nope. Overall, looks good to me. Thanks!

Cheers,
-Matt Helsley


\
 
 \ /
  Last update: 2010-01-15 23:45    [W:0.092 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site