Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH]cfq-iosched: don't take requests with long distence as close | Date | Fri, 15 Jan 2010 15:26:00 -0500 |
| |
Corrado Zoccolo <czoccolo@gmail.com> writes:
> On Fri, Jan 15, 2010 at 8:45 PM, Jeff Moyer <jmoyer@redhat.com> wrote: >> Corrado Zoccolo <czoccolo@gmail.com> writes: >> >>> Hi Jeff, >>> I think this patch has the same flaw as Shaohua's. >>> The seekiness check that you introduce in cfq_rq_close is already >>> present in its caller, cfq_close_cooperator, so it is not effective. >> >> I don't think so. There are two queues, here. One queue is checked by >> the caller, and that is the cur_cfqq. The __cfqq needs to also be >> checked. > The other one, i.e. the returned one, is also checked by the caller, > some lines below.
haha. OK, I guess I wrote it right the first time? ;-)
-Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |