Messages in this thread | | | Date | Fri, 15 Jan 2010 17:54:09 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH] typo in kernel source (DEBUGFS) |
| |
On Fri, 15 Jan 2010, Jiri Kosina wrote:
> > 2010/1/13 Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>: > > > > > While working on this we detected a spelling error in > > > drivers/mfd/ab3100-otp.c which can be corrected using the attached > > > patch. > > > > Acked-by: Linus Walleij <linus.walleij@stericsson.com> > > The original patch misses a Signed-off-by. Please resend it to > trivial@kernel.org with this line, so that it could be applied.
... and has this been tested at all?
drivers/mfd/ab3100-otp.c: In function ‘show_otp’: drivers/mfd/ab3100-otp.c:101: error: dereferencing pointer to incomplete type drivers/mfd/ab3100-otp.c:104: error: implicit declaration of function ‘seq_printf’ drivers/mfd/ab3100-otp.c:102: warning: unused variable ‘err’ drivers/mfd/ab3100-otp.c: In function ‘ab3100_otp_open’: drivers/mfd/ab3100-otp.c:116: error: implicit declaration of function ‘single_open’ drivers/mfd/ab3100-otp.c:116: error: ‘ab3100_otp_show’ undeclared (first use in this function) drivers/mfd/ab3100-otp.c:116: error: (Each undeclared identifier is reported only once drivers/mfd/ab3100-otp.c:116: error: for each function it appears in.) drivers/mfd/ab3100-otp.c: At top level: drivers/mfd/ab3100-otp.c:121: error: ‘seq_read’ undeclared here (not in a function) drivers/mfd/ab3100-otp.c:122: error: ‘seq_lseek’ undeclared here (not in a function) drivers/mfd/ab3100-otp.c:123: error: ‘single_release’ undeclared here (not in a function) drivers/mfd/ab3100-otp.c: In function ‘ab3100_otp_init_debugfs’: drivers/mfd/ab3100-otp.c:134: error: ‘err’ undeclared (first use in this function) drivers/mfd/ab3100-otp.c: In function ‘ab3100_otp_exit_debugfs’: drivers/mfd/ab3100-otp.c:140: error: implicit declaration of function ‘debugfs_remove_file’
So looks like the debugfs code might need some more surgery.
-- Jiri Kosina SUSE Labs, Novell Inc.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |