lkml.org 
[lkml]   [2010]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [RFC] [PATCH] Adding Intel Moorestown PMIC Battery Driver
>>>> +       unsigned int batt_charge_now;           /* in mAS */
>>>> + unsigned int batt_prev_charge_full; /* in mAS */
>>> + unsigned int batt_charge_rate; /* in units per second */
>>>
>>> Per include/linux/power_supply.h and
>>> Documentation/power/power_supply_class.txt
>>>
>>> * All voltages, currents, charges, energies, time and temperatures in uV,
>>> * uA, uAh, uWh, seconds and tenths of degree Celsius unless otherwise
>>> * stated. It's driver's job to convert its raw values to units in which
>>> * this class operates.
>>
>> I just now checked the hardware spec and it is indeed mAh. I will correct
>> the comment appropriately.
>
> Note, if the hardware reports the values in mAh (milli), the driver
> still have to convert them to uAh (micro) before reporting the values
> to userspace.

Yup will take care, sorry for not making it clear here.


Regards,
Nithish
\
 
 \ /
  Last update: 2010-01-15 14:21    [from the cache]
©2003-2011 Jasper Spaans