lkml.org 
[lkml]   [2010]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: [PATCH 20/40] arm,kgdb: Add hook to catch an oops with debugger
Russell King - ARM Linux wrote:
> On Thu, Jan 14, 2010 at 08:59:16AM -0600, Jason Wessel wrote:
>
>> Add in a low level hook to catch calls to die() in the debugger.
>>
>> After the debugger is done, the standard system rules will be in play
>> for the original exception.
>>
>> The kdb debugger wants a chance to catch these sorts of exceptions for
>> analysis.
>>
>
> NAK. I have a similar patch which implements the hook properly - but
> with one caveat. It needs a review to ensure that its safe to return
> from die(). Until that's established, this patch can not be merged.
>

I dropped the patch which you NAK'ed from the series.

As for your included patch, I will try it out against the various
regression tests I have, which exercise the oops and exception paths.

> Please also ensure that the linux-arm-kernel list is copied with ARM
> patches.
>
>

Check.


Thanks,
Jason.


\
 
 \ /
  Last update: 2010-01-14 20:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site