Messages in this thread | | | Date | Thu, 14 Jan 2010 22:08:15 +0800 | From | Wu Fengguang <> | Subject | Re: [ RESEND PATCH v3] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel |
| |
> > 2. pgdat->[start,end], totalram_pages etc...are updated at memory hotplug. > > Please place the hook nearby them. > > arch/x86/mm/init_64.c:arch_add_memory() updates max_pfn_mapped, in > this sense it's equally OK to update max_pfn/max_low_pfn etc before > the call to arch_add_memory() ;)
Shaohui, I'd suggest to update max_pfn/max_low_pfn/high_memory in arch/x86/mm/init_64.c:arch_add_memory() now, for X86_64.
Later on we can add code to arch/x86/mm/init_32.c:arch_add_memory() for X86_32.
The code cannot be shared anyway.
Thanks, Fengguang
| |