lkml.org 
[lkml]   [2010]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/8] vfs: fix too big f_pos handling
On Thu, 14 Jan 2010 05:13:08 +0000
Al Viro <viro@ZenIV.linux.org.uk> wrote:

> On Wed, Jan 13, 2010 at 10:09:56PM +0800, Wu, Fengguang wrote:
> > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> >
> > Now, rw_verify_area() checsk f_pos is negative or not. And if
> > negative, returns -EINVAL.
> >
> > But, some special files as /dev/(k)mem and /proc/<pid>/mem etc..
> > has negative offsets. And we can't do any access via read/write
> > to the file(device).
> >
> > This patch introduce a flag S_VERYBIG and allow negative file
> > offsets.
>
> Ehh... FMODE_NEG_OFFSET in file->f_mode, perhaps?
>
Any method is okay for me.
I was just not sure where I could modify without problem.
If modifing f_mode is allowed, I'll write new version.

Thank you for advice.

I'm sorry that I don't have enough time this week. So, I'll try next week.
I think dropping this patch itself has no big influence to this patch set.
(but debug will be harder ;)
Thanks,
-Kame



\
 
 \ /
  Last update: 2010-01-14 06:49    [W:0.041 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site