Messages in this thread | | | Date | Thu, 14 Jan 2010 13:39:15 +0100 | From | Tilman Schmidt <> | Subject | Re: Can we remove pci_find_device() yet? |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2010-01-14 12:03 schrieb Andi Kleen: > On Thu, Jan 14, 2010 at 11:02:14AM +0000, Alan Cox wrote: [It would be better to enforce this constraint at runtime.] >> There is a simpler way to do that, which is to just leak a reference in >> the hisax_find_pci_device hack. The pci_dev won't be going anywhere then. > > You just have to do it once, otherwise it'll fail after 4 billion times.
I guess we could live with that. pci_find_device() or its successor, the hisax_find_pci_device() hack, is only called during device setup, once for most drivers and at the very most 24 times for hfc_pci. Someone would have to rmmod/insmod a HiSax module more than a hundred million times to accumulate four billion calls.
- -- Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAktPEHMACgkQQ3+did9BuFuQ/gCgkhu6RJIwrpIDAJMWbO1mZgOd BKwAnAh6kX5F/+dFPIrK/XLovEAv/R7O =fflE -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |