lkml.org 
[lkml]   [2010]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch 2/6] hugetlb: Fix section mismatches
    From
    Date
    On Tue, 2010-01-12 at 19:48 -0500, Jeff Mahoney wrote:
    > plain text document attachment (patches.rpmify)
    > hugetlb_register_node calls hugetlb_sysfs_add_hstate, which is marked with
    > __init. Since hugetlb_register_node is only called by
    > hugetlb_register_all_nodes, which in turn is only called by hugetlb_init,
    > it's safe to mark both of them as __init.

    Actually, hugetlb_register_node() also called, via a function pointer
    that hugetlb registers with the sysfs node driver, when a node is hot
    plugged. So, I think the correct approach is to remove the '__init'
    from hugetlb_sysfs_add_hstate() as this is also used at runtime. I
    missed this in the original submittal.

    Regards,
    Lee Schermerhorn

    >
    > Signed-off-by: Jeff Mahoney <jeffm@suse.com>
    > ---
    > mm/hugetlb.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > --- a/mm/hugetlb.c
    > +++ b/mm/hugetlb.c
    > @@ -1630,7 +1630,7 @@ void hugetlb_unregister_node(struct node
    > * hugetlb module exit: unregister hstate attributes from node sysdevs
    > * that have them.
    > */
    > -static void hugetlb_unregister_all_nodes(void)
    > +static void __init hugetlb_unregister_all_nodes(void)
    > {
    > int nid;
    >
    > @@ -1650,7 +1650,7 @@ static void hugetlb_unregister_all_nodes
    > * Register hstate attributes for a single node sysdev.
    > * No-op if attributes already registered.
    > */
    > -void hugetlb_register_node(struct node *node)
    > +void __init hugetlb_register_node(struct node *node)
    > {
    > struct hstate *h;
    > struct node_hstate *nhs = &node_hstates[node->sysdev.id];
    >
    >
    > --
    > To unsubscribe, send a message with 'unsubscribe linux-mm' in
    > the body to majordomo@kvack.org. For more info on Linux MM,
    > see: http://www.linux-mm.org/ .
    > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>



    \
     
     \ /
      Last update: 2010-01-13 16:43    [W:0.022 / U:0.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site