Messages in this thread Patch in this message | | | Date | Wed, 13 Jan 2010 21:53:08 +0800 | From | Wu Fengguang <> | Subject | [PATCH 3/8] devmem: fix kmem write bug on memory holes |
| |
write_kmem() used to assume vwrite() always return the full buffer length. However now vwrite() could return 0 to indicate memory hole. This creates a bug that "buf" is not advanced accordingly.
Fix it to simply ignore the return value, hence the memory hole.
CC: Kelly Bowa <kmb@tuxedu.org> CC: Andi Kleen <andi@firstfloor.org> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org> CC: Christoph Lameter <cl@linux-foundation.org> CC: Ingo Molnar <mingo@elte.hu> CC: Tejun Heo <tj@kernel.org> CC: Nick Piggin <npiggin@suse.de> CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> CC: <stable@kernel.org> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> --- drivers/char/mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-mm.orig/drivers/char/mem.c 2010-01-11 10:32:32.000000000 +0800 +++ linux-mm/drivers/char/mem.c 2010-01-11 10:32:34.000000000 +0800 @@ -555,7 +555,7 @@ static ssize_t write_kmem(struct file * err = -EFAULT; break; } - sz = vwrite(kbuf, (char *)p, sz); + vwrite(kbuf, (char *)p, sz); count -= sz; buf += sz; virtr += sz;
| |