lkml.org 
[lkml]   [2010]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] netpoll: allow execution of multiple rx_hooks per interface
    Date
    Daniel Borkmann <danborkmann@googlemail.com> writes:

    > Daniel Borkmann wrote:
    >> Matt Mackall wrote:
    >>> On Mon, 2010-01-11 at 15:59 -0800, David Miller wrote:
    >>>> From: Matt Mackall <mpm@selenic.com>
    >>>> Date: Mon, 11 Jan 2010 17:21:48 -0600
    >>>>
    >>>>> Looks pretty good. Dave?
    >>>>>
    >>>>> Acked-by: Matt Mackall <mpm@selenic.com>
    >>>> I don't like the loop for RX ARP processing.
    >>>>
    >>>> The packet contents aren't going to change, so doing basic
    >>>> packet validation inside of the "for each RX client" loop
    >>>> of arp_reply() doesn't make any sense.
    >>> True. Dan, please help our poor compilers with some manual loop
    >>> invariant motion.
    >>
    >> Okay, true. I'll fix this by tomorrow and resend the patch.
    >
    > Here the fix of the RX ARP processing routine. Content that isn't
    > going to change is out-of-loop.
    > Successfully tested on my machines.

    Against what tree does this patch apply? It doesn't apply to Linus's
    git tree. Also, in the future, could you use the -p option to diff so
    we can see what function or data structure is being modified? It really
    helps in reviewing.

    Thanks!
    Jeff


    \
     
     \ /
      Last update: 2010-01-13 14:59    [W:0.023 / U:0.408 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site