Messages in this thread | | | Date | Tue, 12 Jan 2010 00:50:52 -0800 | Subject | Re: [RFC PATCH 4/4] x86: according to nr_cpu_ids to decide if need to leave logical flat | From | Yinghai Lu <> |
| |
On Mon, Jan 11, 2010 at 7:20 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > > On Mon, 11 Jan 2010, Yinghai Lu wrote: >> + >> +void default_setup_apic_routing(void) > > Good cleanup, makes x86-64 and x86-32 look similar. However, you should > mark it __init too, I think, to match the current probe_64.c thing. > > Also, what about the default_setup_apic_routing() call in > arch/x86/kernel/apic/apic.c? Is that not ripe for unification too now? You > only did the smpboot.c one, not the APIC_init_uniprocessor() one. > that was intentionally. because one cpu, don't need to switch to bigsmp..
will make the change to that to make them consistent.
YH
| |