Messages in this thread | | | Date | Tue, 12 Jan 2010 16:59:42 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: x86-32: clean up rwsem inline asm statements |
| |
On Tue, 12 Jan 2010, H. Peter Anvin wrote: > > As far as I can tell, very few of these assembly statements actually > need a size at all -- the very first inc statement is purely to memory, > and as such it needs a size marker, but almost any operation which is > register-register or register-memory will simply take its size from the > register operand. For those, it seems cleaner to simply drop the size > suffix, and in fact this is the style we have been pushing people > towards (use the suffix where mandatory or where the size is fixed > anyway, to help catch bugs; use no suffix where the size can vary and is > implied by the operands.) > > So, proposed alternate version of your patch attached.
Looks good to me.
Linus
| |