Messages in this thread |  | | | Date | Tue, 12 Jan 2010 12:18:14 +0530 | | Subject | Re: [PATCH] Fix reset of ramzswap | | From | Nitin Gupta <> |
| |
On Tue, Jan 12, 2010 at 11:18 AM, Minchan Kim <minchan.kim@gmail.com> wrote: > On Tue, 2010-01-12 at 11:00 +0530, Nitin Gupta wrote: >> On Tue, Jan 12, 2010 at 10:06 AM, minchan.kim <minchan.kim@gmail.com> wrote:
>> >> Are you sure you checked this patch? > >> This check makes sure that you cannot reset an active swap device. >> When device in swapoff'ed the ioctl works as expected. >> > It seems my test was wrong. > Maybe my test case don't swapoff swap device. > Sorry. Ignore this patch, pz. > Thanks for the reivew, Nitin. > > I have one more patch. But I don't want to conflict your pending > patches. If it is right, pz, merge this patch with your pending series. >
I will merge your patches with my pending series and add appropriate signed-off-by lines.
> >From bf810ec09761b0f37eca7ba22d72fb2b1f2cba50 Mon Sep 17 00:00:00 2001 > From: Minchan Kim <minchan.kim@gmail.com> > Date: Tue, 12 Jan 2010 14:46:46 +0900 > Subject: [PATCH] Remove unnecessary check of ramzswap_write > > Nitin already implement swap slot free callback. > So, we don't need this test any more. > > Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
Great catch! thanks.
I think, we should avoid adding linux-mm to CC list (unless its about xvmalloc allocator). LKML alone should be sufficient.
Thanks, Nitin
|  |