Messages in this thread | | | Date | Mon, 11 Jan 2010 19:20:29 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [RFC PATCH 4/4] x86: according to nr_cpu_ids to decide if need to leave logical flat |
| |
On Mon, 11 Jan 2010, Yinghai Lu wrote: > + > +void default_setup_apic_routing(void)
Good cleanup, makes x86-64 and x86-32 look similar. However, you should mark it __init too, I think, to match the current probe_64.c thing.
Also, what about the default_setup_apic_routing() call in arch/x86/kernel/apic/apic.c? Is that not ripe for unification too now? You only did the smpboot.c one, not the APIC_init_uniprocessor() one.
Hmm?
Linus
| |