lkml.org 
[lkml]   [2010]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 4/4] x86: according to nr_cpu_ids to decide if need to leave logical flat


    On Mon, 11 Jan 2010, Yinghai Lu wrote:
    > +
    > +void default_setup_apic_routing(void)

    Good cleanup, makes x86-64 and x86-32 look similar. However, you should
    mark it __init too, I think, to match the current probe_64.c thing.

    Also, what about the default_setup_apic_routing() call in
    arch/x86/kernel/apic/apic.c? Is that not ripe for unification too now? You
    only did the smpboot.c one, not the APIC_init_uniprocessor() one.

    Hmm?

    Linus


    \
     
     \ /
      Last update: 2010-01-12 04:25    [W:0.021 / U:0.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site