Messages in this thread | | | Date | Tue, 12 Jan 2010 10:50:12 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1) |
| |
On Tue, 12 Jan 2010 10:39:44 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Tue, 12 Jan 2010 02:38:09 +0100 > Andi Kleen <ak@linux.intel.com> wrote: > > > > > > Hmmm....could you rewrite /dev/mem to use kernel/resource.c other than > > > modifing e820 maps. ? > > > > Sorry but responding to bug fixes with "could you please rewrite ..." is > > not considered fair. Shaohui is just trying to fix a bug here, not redesigning > > a subsystem. > > > Quick hack for bug fix is okay to me. > Just an information.
We already check kenerke/resource.c's resource information, here.
read_mem() -> range_is_allowed() -> devmem_is_allowd() -> iomem_is_exclusive()
extra calls of page_is_ram() to ask architecture's map seems redundunt.
But, I know PPC guys doesn't use ioresource.c, hehe.
Thanks, -Kame
| |