Messages in this thread | | | Date | Sun, 10 Jan 2010 12:23:01 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH 1/1] Char: synclink, fix potential null dereference |
| |
On 01/10/2010 09:51 AM, Jiri Slaby wrote: > Stanse found a potential null dereference in mgsl_put_char and > mgsl_write. There is a check for tty being NULL, but it is > dereferenced earlier. Move the dereference after the check. > > Also reorder mgsl_paranoia_check so that it makes sense: > * check !tty > * deref tty > * check !info > * deref info
Actually, this is wrong, .write and .put_char cannot be called with NULL tty.
-- js
| |