lkml.org 
[lkml]   [2010]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: MSI broken in libata?
Hello, Robert.

On 01/11/2010 10:39 AM, Robert Hancock wrote:
> It'd be interesting to see if it makes a difference, but I don't think
> the patch is quite right. According to the datasheet, doing the MSI ack
> while the interrupt source is still pending will cause a new MSI to be
> sent, so if you do it before handling the interrupt you'll generate a
> spurious interrupt after every real one.

Ah... okay, so the generation of MSI is level triggered? If so, your
original patch is correct. I was thinking it might be edge triggered
and it should be cleared before checking master event mask.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2010-01-11 03:19    [W:0.079 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site