Messages in this thread | | | Date | Sun, 10 Jan 2010 20:43:51 +0100 | From | Németh Márton <> | Subject | Re: [PATCH 3/3] serial: make PCI device id constant |
| |
Michał Mirosław wrote: > 2010/1/10 Németh Márton <nm127@freemail.hu>: >> From: Márton Németh <nm127@freemail.hu> >> >> The id_table field of the struct pci_driver is constant in <linux/pci.h> >> so it is worth to make initialization data also constant. > [...] >> diff -u -p a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c >> --- a/drivers/serial/8250_pci.c 2009-12-03 04:51:21.000000000 +0100 >> +++ b/drivers/serial/8250_pci.c 2010-01-08 18:40:05.000000000 +0100 >> @@ -2567,7 +2567,7 @@ static int pciserial_resume_one(struct p >> } >> #endif >> >> -static struct pci_device_id serial_pci_tbl[] = { >> +static const struct pci_device_id serial_pci_tbl[] = { >> /* Advantech use PCI_DEVICE_ID_ADVANTECH_PCI3620 (0x3620) as 'PCI_SUBVENDOR_ID' */ >> { PCI_VENDOR_ID_ADVANTECH, PCI_DEVICE_ID_ADVANTECH_PCI3620, >> PCI_DEVICE_ID_ADVANTECH_PCI3620, 0x0001, 0, 0, > [...] > > There was similar patch sent to netdev couple days ago. For PCI > devices it used DEFINE_PCI_DEVICE_TABLE() like this: > > static DEFINE_PCI_DEVICE_TABLE(serial_pci_tbl) = { > > so that the ID data went to the proper .ko section.
Thanks for the feedback. The DEFINE_PCI_DEVICE_TABLE() is also recommended by Documentation/PCI/pci.txt .
Regads,
Márton Németh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |