lkml.org 
[lkml]   [2010]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drivers/input/joystick/xpad.c: Add rumble support for original xbox controller
    On Fri, Jan 08, 2010 at 11:26:10AM +0100, Benjamin Valentin wrote:
    > On Thu, 7 Jan 2010 23:50:54 -0800
    > Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
    >
    > > Thank you for your patch. Could I please have your "Signed-off-by: "
    > > so I can apply it? Also, if you have any more patches ofr in put
    > > devices, could you please CC linux-input@vger.kernel.org?
    >
    > This way?
    >
    > Signed-off-by: Benjamin Valentin <benpicco@zedat.fu-berlin.de>

    Yep, thanks.

    >
    > --- /usr/src/linux-source-2.6.33/drivers/input/joystick/xpad.c
    > 2010-01-08 02:56:59.365851076 +0100 +++ xpad.c 2010-01-08
    > 03:13:38.477835651 +0100 @@ -505,7 +505,7 @@
    > struct usb_endpoint_descriptor *ep_irq_out;
    > int error = -ENOMEM;
    >
    > - if (xpad->xtype != XTYPE_XBOX360)
    > + if (xpad->xtype != XTYPE_XBOX360 && xpad->xtype != XTYPE_XBOX)
    > return 0;
    >
    > xpad->odata = usb_buffer_alloc(xpad->udev, XPAD_PKT_LEN,
    > @@ -535,13 +535,13 @@
    >
    > static void xpad_stop_output(struct usb_xpad *xpad)
    > {
    > - if (xpad->xtype == XTYPE_XBOX360)
    > + if (xpad->xtype == XTYPE_XBOX360 || xpad->xtype != XTYPE_XBOX)

    This should cretainly be "... || xpad->xtype == XTYPE_XBOX)", I'll fix
    it up locally.

    > usb_kill_urb(xpad->irq_out);
    > }
    >
    > static void xpad_deinit_output(struct usb_xpad *xpad)
    > {
    > - if (xpad->xtype == XTYPE_XBOX360) {
    > + if (xpad->xtype == XTYPE_XBOX360 || xpad->xtype != XTYPE_XBOX)

    Same here.

    BTW, your mailer line-wraps e-mail which is bad when sending patches.

    --
    Dmitry


    \
     
     \ /
      Last update: 2010-01-10 08:59    [W:0.022 / U:0.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site