lkml.org 
[lkml]   [2009]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] SCSI driver for VMware's virtual HBA - V4.
From
Date
On Tue, 2009-09-08 at 18:15 -0700, Alok Kataria wrote:
> +typedef struct PVSCSIRingCmpDesc {
> + u64 context;
> + u64 dataLen;
> + u32 senseLen;
> + u16 hostStatus;
> + u16 scsiStatus;
> + u32 _pad[2];
> +} __packed PVSCSIRingCmpDesc;


I get a lot of checkpatch warnings due to the typedefs here.. They are
usually frowned upon, and it really does make you code look alien ..

> +#define PVSCSI_MEM_SPACE_COMMAND_PAGE 0
> +#define PVSCSI_MEM_SPACE_INTR_STATUS_PAGE 1
> +#define PVSCSI_MEM_SPACE_MISC_PAGE 2
> +#define PVSCSI_MEM_SPACE_KICK_IO_PAGE 4
> +#define PVSCSI_MEM_SPACE_MSIX_TABLE_PAGE 6
> +#define PVSCSI_MEM_SPACE_MSIX_PBA_PAGE 7

Why not use an enum for the above? Your using enums in the rest of your
code..

Daniel



\
 
 \ /
  Last update: 2009-09-09 03:29    [W:0.219 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site