Messages in this thread | | | Date | Tue, 8 Sep 2009 14:34:31 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 8/8] jffs2/jfs/xfs: switch over to 'check_acl' rather than 'permission()' |
| |
The split of these patches is a bit odd, either do all in one patch or one patch per filesystem instead of those groups.
That beeing said if we go down this way I would prefer if we go down all the way, that is convert the remaining few filesystems that pass a check_acl argument to generic_permission (btrfs, gfs2, ocfs2) and just kill off that argument.
After that there is another step we can easily go: as we now cache the ACLs in the generic inode instead of the per-fs one we can move the get_cached_acl call to your acl_permission_check helper (for gfs2/ocfs2 that don't cache ACLs it will always fail), and not call out to the fs for the fast path at all.
| |