lkml.org 
[lkml]   [2009]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 10 update 2x] PM: Measure suspend and resume times for individual devices
Date
On Sunday 06 September 2009, Ingo Molnar wrote:
>
> Thanks Rafael, the code looks a lot more natural IMHO.
>
> this bit:
>
> > +#ifdef DEBUG
> > +static void dbg_get_time(struct timeval *start)
> > +{
> > + do_gettimeofday(start);
> > +}
>
> is a plain wrapper over gettimeofday so you might want to inline
> it. (although GCC will do it too most of the time)

I have a rule of not using 'inline' except for in headers. In this case,
however, it's almost like a header, so I'll follow your suggestion.

Thanks,
Rafael


\
 
 \ /
  Last update: 2009-09-06 14:17    [W:0.063 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site