Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 10 update 2x] PM: Measure suspend and resume times for individual devices | Date | Sun, 6 Sep 2009 14:13:43 +0200 |
| |
On Sunday 06 September 2009, Ingo Molnar wrote: > > Thanks Rafael, the code looks a lot more natural IMHO. > > this bit: > > > +#ifdef DEBUG > > +static void dbg_get_time(struct timeval *start) > > +{ > > + do_gettimeofday(start); > > +} > > is a plain wrapper over gettimeofday so you might want to inline > it. (although GCC will do it too most of the time)
I have a rule of not using 'inline' except for in headers. In this case, however, it's almost like a header, so I'll follow your suggestion.
Thanks, Rafael
| |