lkml.org 
[lkml]   [2009]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 01/18] ring-buffer: do not reset while in a commit
    From: Steven Rostedt <srostedt@redhat.com>

    The callers of reset must ensure that no commit can be taking place
    at the time of the reset. If it does then we may corrupt the ring buffer.

    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    kernel/trace/ring_buffer.c | 4 ++++
    1 files changed, 4 insertions(+), 0 deletions(-)

    diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
    index da2c59d..79d6012 100644
    --- a/kernel/trace/ring_buffer.c
    +++ b/kernel/trace/ring_buffer.c
    @@ -3373,12 +3373,16 @@ void ring_buffer_reset_cpu(struct ring_buffer *buffer, int cpu)

    spin_lock_irqsave(&cpu_buffer->reader_lock, flags);

    + if (RB_WARN_ON(cpu_buffer, local_read(&cpu_buffer->committing)))
    + goto out;
    +
    __raw_spin_lock(&cpu_buffer->lock);

    rb_reset_cpu(cpu_buffer);

    __raw_spin_unlock(&cpu_buffer->lock);

    + out:
    spin_unlock_irqrestore(&cpu_buffer->reader_lock, flags);

    atomic_dec(&cpu_buffer->record_disabled);
    --
    1.6.3.3
    --


    \
     
     \ /
      Last update: 2009-09-05 02:05    [W:4.228 / U:0.548 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site