Messages in this thread | | | Date | Fri, 4 Sep 2009 20:34:04 +0400 | From | Anton Vorontsov <> | Subject | Re: [PATCH 2/5] pda-power: switch to new dev_pm_ops |
| |
On Fri, Aug 07, 2009 at 03:35:19PM +0200, pHilipp Zabel wrote: [...] > > +static struct dev_pm_ops pda_power_pm_ops = { > > + .poweroff = pda_power_poweroff, > > + .restore = pda_power_restore, > > +}; > > No no, now you're missing .suspend/.resume. As I understand it, the > suspend and hibernation codepaths are now completely separate. > > Also, I'm not sure using .restore here is quite correct. > enable_irq_wake is called in .poweroff, after .freeze + creation of > the memory image. So if this memory image is restored during the next > boot, there is no trace of irq wakup ever being enabled and thus no > need to call disable_irq_wake. > > I think just .suspend/.poweroff and .resume need to be used for this driver.
Daniel, any update on this patch?
Thanks,
-- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |